The dock stays live underneath fault screen 6a, so 送信 raises an error into a fault #65
Labels
No labels
needs-info
needs-triage
ready-for-agent
ready-for-human
v2
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wayfinder:ticket
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
aiko/denpa#65
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
denpa#59shipped fault screen 6a — the socket will not open. The dock's keys are not held while it is up, so 送信 is still pressable underneath it and raiseserror.websocketNotOpen.That is an error thrown by pressing a key that the app is currently drawing a full-screen explanation of. The operator is told the socket is down and then told again, less well, when they touch anything.
An approval already holds the mic keys (
micHeld), so the pattern exists and the fault case simply does not use it. The likely fix is that a fault holds the same keys an approval does, but it is worth deciding deliberately which keys a fault holds — 文 compose, for instance, is just as dead as 送信 when the socket is shut, whereas the fault screen's own actions must obviously stay live.Acceptance
Merged to
maininee25aaa.Fix. A fault holds the keys that cannot work under it.
receiver-chrome.tsxderivessocketHeldfromfault.kind === 'socket-closed'and threads it intoDock,TransmissionBandandKeyRow, so 送信, ハンズフリー and 文 go disabled instead of raising an error into a fault screen.Tests. Gate on merged main: 62 files / 854 tests passing.
Not covered here.
PalBarnever got the same rule, so pet mode and the Android overlay still keep those keys live under the same fault. Filed as #71, which asks for one shared predicate overTwoHopStatusrather than a third hand-derived flag.