Three inbound handlers survive with no producer anywhere #63

New issue

Closed

opened 2026-07-30 21:52:47 +00:00 by aiko · 1 comment

aiko commented

2026-07-30 21:52:47 +00:00

Owner

denpa#50 stopped the client sending fetch-history-list and create-new-history to a go-between that had deleted both. The receiving half was left behind.

src/renderer/src/services/websocket-handler.tsx still handles:

:203 — history-data
:213 — new-history-created
:242 — history-list

Grepping denpa/src and denpa/hermes_plugin finds no producer for any of the three. They are dead branches waiting on frames that nothing will ever send.

Two comments still reason about the replay path as though it happens — components/receiver/log-rows.ts:63 and components/receiver/receiver-chrome.tsx:157 both describe what a history-data replay does to a running relay row. Dead code that documents itself is worse than dead code, because the next reader takes it for a live path.

Acceptance

The three cases are deleted from websocket-handler.tsx
The two comments that describe the replay are deleted or corrected
cut-surfaces.test.ts gains the three names alongside the ones it already asserts the absence of
Nothing else in the client references a history replay

Deletion only. If something turns out to still need one of these, say so on the issue instead of keeping it alive quietly.

`denpa#50` stopped the client *sending* `fetch-history-list` and `create-new-history` to a go-between that had deleted both. The receiving half was left behind. `src/renderer/src/services/websocket-handler.tsx` still handles: - `:203` — `history-data` - `:213` — `new-history-created` - `:242` — `history-list` Grepping `denpa/src` and `denpa/hermes_plugin` finds **no producer for any of the three**. They are dead branches waiting on frames that nothing will ever send. Two comments still reason about the replay path as though it happens — `components/receiver/log-rows.ts:63` and `components/receiver/receiver-chrome.tsx:157` both describe what a `history-data` replay does to a running relay row. Dead code that documents itself is worse than dead code, because the next reader takes it for a live path. ## Acceptance - [ ] The three cases are deleted from `websocket-handler.tsx` - [ ] The two comments that describe the replay are deleted or corrected - [ ] `cut-surfaces.test.ts` gains the three names alongside the ones it already asserts the absence of - [ ] Nothing else in the client references a history replay Deletion only. If something turns out to still need one of these, say so on the issue instead of keeping it alive quietly.

aiko added the

ready-for-agent

wayfinder:ticket

labels

2026-07-30 21:52:48 +00:00

aiko commented

2026-07-31 14:33:34 +00:00

Author

Owner

This was generated by AI during triage.

Merged to main in ee25aaa.

Fix. The three inbound handlers with no producer are gone, both directions: history-drawer.tsx (-134) and use-history-drawer.ts (-75) deleted, with the matching cuts in websocket-handler.tsx, websocket-service.tsx, log-rows.ts and chat-history-context.tsx.

Tests. cut-surfaces.test.ts gained assertions pinning the sends as well as the receives, so re-adding either direction fails. Gate on merged main: 62 files / 854 tests passing.

Left standing, deliberately. history-deleted is dead by the same argument and three locale strings are now unreferenced. Neither is named by this issue; both want their own ticket rather than a silent widening here.

> *This was generated by AI during triage.* Merged to `main` in `ee25aaa`. **Fix.** The three inbound handlers with no producer are gone, both directions: `history-drawer.tsx` (-134) and `use-history-drawer.ts` (-75) deleted, with the matching cuts in `websocket-handler.tsx`, `websocket-service.tsx`, `log-rows.ts` and `chat-history-context.tsx`. **Tests.** `cut-surfaces.test.ts` gained assertions pinning the sends as well as the receives, so re-adding either direction fails. Gate on merged main: 62 files / 854 tests passing. **Left standing, deliberately.** `history-deleted` is dead by the same argument and three locale strings are now unreferenced. Neither is named by this issue; both want their own ticket rather than a silent widening here.

aiko closed this issue

2026-07-31 14:33:34 +00:00

aiko referenced this issue from a commit

2026-08-07 08:57:15 +00:00

refactor(log): cut the history replay path, both directions

aiko referenced this issue from a commit

2026-08-07 08:57:15 +00:00

fix(canvas): keep the canvas mounted through the onboarding gate too

aiko referenced this issue from a commit

2026-08-07 08:57:15 +00:00

Merge the #62-#68 batch